netdev - Re: [PATCH] net: phylink: set the autoneg state in phylink_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190615221328.4diebpopfzyfi4og@shell.armlinux.org.uk>
Date:   Sat, 15 Jun 2019 23:13:28 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     David Miller <davem@...emloft.net>
Cc:     ioana.ciornei@....com, andrew@...n.ch, f.fainelli@...il.com,
        hkallweit1@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phylink: set the autoneg state in phylink_phy_change

On Sat, Jun 15, 2019 at 01:30:21PM -0700, David Miller wrote:
> From: Ioana Ciornei <ioana.ciornei@....com>
> Date: Thu, 13 Jun 2019 09:37:51 +0300
> 
> > The phy_state field of phylink should carry only valid information
> > especially when this can be passed to the .mac_config callback.
> > Update the an_enabled field with the autoneg state in the
> > phylink_phy_change function.
> > 
> > Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> 
> Applied and queued up for -stable, thanks.

This is not a fix; it is an attempt to make phylink work differently
from how it's been designed for the dpaa2 driver.  I've already stated
that this field is completely meaningless, so I'm surprised you
applied it.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up