netdev - Re: [PATCH net-next] net: sched: ingress: set 'unlocked' flag for clsact Qdisc ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190614.193407.464864156424103215.davem@davemloft.net>
Date:   Fri, 14 Jun 2019 19:34:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vladbu@...lanox.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, daniel@...earbox.net
Subject: Re: [PATCH net-next] net: sched: ingress: set 'unlocked' flag for
 clsact Qdisc ops

From: Vlad Buslov <vladbu@...lanox.com>
Date: Thu, 13 Jun 2019 19:12:05 +0300

> To remove rtnl lock dependency in tc filter update API when using clsact
> Qdisc, set QDISC_CLASS_OPS_DOIT_UNLOCKED flag in clsact Qdisc_class_ops.
> 
> Clsact Qdisc ops don't require any modifications to be used without rtnl
> lock on tc filter update path. Implementation never changes its q->block
> and only releases it when Qdisc is being destroyed. This means it is enough
> for RTM_{NEWTFILTER|DELTFILTER|GETTFILTER} message handlers to hold clsact
> Qdisc reference while using it without relying on rtnl lock protection.
> Unlocked Qdisc ops support is already implemented in filter update path by
> unlocked cls API patch set.
> 
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Applied.