netdev - [PATCH net-next] selftests/net: fix warnings in TFO key rotation selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190616171501.142551-1-willemdebruijn.kernel@gmail.com>
Date:   Sun, 16 Jun 2019 13:15:01 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, jbaron@...mai.com,
        Willem de Bruijn <willemb@...gle.com>
Subject: [PATCH net-next] selftests/net: fix warnings in TFO key rotation selftest

From: Willem de Bruijn <willemb@...gle.com>

One warning each on signedness, unused variable and return type.

Fixes: 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest")
Signed-off-by: Willem de Bruijn <willemb@...gle.com>
---
 tools/testing/selftests/net/tcp_fastopen_backup_key.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/net/tcp_fastopen_backup_key.c b/tools/testing/selftests/net/tcp_fastopen_backup_key.c
index 58bb77d9e7e1..9c55ec44fc43 100644
--- a/tools/testing/selftests/net/tcp_fastopen_backup_key.c
+++ b/tools/testing/selftests/net/tcp_fastopen_backup_key.c
@@ -51,7 +51,7 @@ static const int PORT = 8891;
 static void get_keys(int fd, uint32_t *keys)
 {
 	char buf[128];
-	int len = KEY_LENGTH * 2;
+	socklen_t len = KEY_LENGTH * 2;
 
 	if (do_sockopt) {
 		if (getsockopt(fd, SOL_TCP, TCP_FASTOPEN_KEY, keys, &len))
@@ -210,14 +210,13 @@ static bool is_listen_fd(int fd)
 	return false;
 }
 
-static int rotate_key(int fd)
+static void rotate_key(int fd)
 {
 	static int iter;
 	static uint32_t new_key[4];
 	uint32_t keys[8];
 	uint32_t tmp_key[4];
 	int i;
-	int len = KEY_LENGTH * 2;
 
 	if (iter < N_LISTEN) {
 		/* first set new key as backups */
-- 
2.22.0.410.gd8fdbe21b5-goog