netdev - Re: [PATCH 1/1] ARM: dts: stm32: replace rgmii mode with rgmii-id on stm32mp15 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Jun 2019 14:34:49 +0200
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Christophe Roullier <christophe.roullier@...com>,
        <robh@...nel.org>, <davem@...emloft.net>, <joabreu@...opsys.com>,
        <mark.rutland@....com>, <mcoquelin.stm32@...il.com>,
        <peppe.cavallaro@...com>
CC:     <linux-stm32@...md-mailman.stormreply.com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <andrew@...n.ch>
Subject: Re: [PATCH 1/1] ARM: dts: stm32: replace rgmii mode with rgmii-id on
 stm32mp15 boards

Hi Christophe

On 6/17/19 10:50 AM, Christophe Roullier wrote:
> On disco and eval board, Tx and Rx delay are applied (pull-up of 4.7k
> put on VDD) so which correspond to RGMII-ID mode with internal RX and TX
> delays provided by the PHY, the MAC should not add the RX or TX delays
> in this case
> 
> Signed-off-by: Christophe Roullier <christophe.roullier@...com>
> ---
>   arch/arm/boot/dts/stm32mp157a-dk1.dts | 2 +-
>   arch/arm/boot/dts/stm32mp157c-ev1.dts | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> index 098dbfb06b61..2c105740dfad 100644
> --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> @@ -51,7 +51,7 @@
>   	pinctrl-0 = <&ethernet0_rgmii_pins_a>;
>   	pinctrl-1 = <&ethernet0_rgmii_pins_sleep_a>;
>   	pinctrl-names = "default", "sleep";
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>   	max-speed = <1000>;
>   	phy-handle = <&phy0>;
>   
> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> index b6aca40b9b90..ab1393caf799 100644
> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> @@ -79,7 +79,7 @@
>   	pinctrl-0 = <&ethernet0_rgmii_pins_a>;
>   	pinctrl-1 = <&ethernet0_rgmii_pins_sleep_a>;
>   	pinctrl-names = "default", "sleep";
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>   	max-speed = <1000>;
>   	phy-handle = <&phy0>;
>   
> 

Applied on stm32-next.

Thanks.
Alex