[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190617170805.GA5736@ubuntu>
Date: Mon, 17 Jun 2019 13:08:05 -0400
From: Stephen Suryaputra <ssuryaextr@...il.com>
To: David Ahern <dsahern@...il.com>
Cc: Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org,
nikolay@...ulusnetworks.com
Subject: Re: [PATCH net-next v3] ipv4: Support multipath hashing on inner IP
pkts for GRE tunnel
On Mon, Jun 17, 2019 at 09:53:06AM -0600, David Ahern wrote:
> On 6/17/19 8:39 AM, Ido Schimmel wrote:
> >
> > Do you plan to add IPv6 support? Would be good to have the same features
> > in both stacks.
>
> we really should be mandating equal support for all new changes like this.
>
I will add that.
> >
> > Also, we have tests for these sysctls under
> > tools/testing/selftests/net/forwarding/router_multipath.sh
> >
> > Can you add a test for this change as well? You'll probably need to
> > create a new file given the topology created by router_multipath.sh does
> > not include tunnels.
I never looked at the selftests scripts, but will attempt.
Stephen.
Powered by blists - more mailing lists