netdev - [PATCH net v2 0/2] net: netem: fix issues with corrupting GSO frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190617181111.5025-1-jakub.kicinski@netronome.com>
Date:   Mon, 17 Jun 2019 11:11:09 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     davem@...emloft.net, xiyou.wangcong@...il.com
Cc:     stephen@...workplumber.org, jhs@...atatu.com, jiri@...nulli.us,
        netem@...ts.linux-foundation.org, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, edumazet@...gle.com, posk@...gle.com,
        nhorman@...driver.com
Subject: [PATCH net v2 0/2] net: netem: fix issues with corrupting GSO frames

Hi!

Corrupting GSO frames currently leads to crashes, due to skb use
after free.  These stem from the skb list handling - the segmented
skbs come back on a list, and this list is not properly unlinked
before enqueuing the segments.  Turns out this condition is made
very likely to occur because of another bug - in backlog accounting.
Segments are counted twice, which means qdisc's limit gets reached
leading to drops and making the use after free very likely to happen.

The bugs are fixed in order in which they were added to the tree.

Jakub Kicinski (2):
  net: netem: fix backlog accounting for corrupted GSO frames
  net: netem: fix use after free and double free with packet corruption

 net/sched/sch_netem.c | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

-- 
2.21.0