lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 16 Jun 2019 20:44:57 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jeremy@...zel.net Cc: linux-x25@...r.kernel.org, netdev@...r.kernel.org, syzbot+afb980676c836b4a0afa@...kaller.appspotmail.com Subject: Re: [PATCH net] lapb: fixed leak of control-blocks. From: Jeremy Sowden <jeremy@...zel.net> Date: Sun, 16 Jun 2019 16:54:37 +0100 > lapb_register calls lapb_create_cb, which initializes the control- > block's ref-count to one, and __lapb_insert_cb, which increments it when > adding the new block to the list of blocks. > > lapb_unregister calls __lapb_remove_cb, which decrements the ref-count > when removing control-block from the list of blocks, and calls lapb_put > itself to decrement the ref-count before returning. > > However, lapb_unregister also calls __lapb_devtostruct to look up the > right control-block for the given net_device, and __lapb_devtostruct > also bumps the ref-count, which means that when lapb_unregister returns > the ref-count is still 1 and the control-block is leaked. > > Call lapb_put after __lapb_devtostruct to fix leak. > > Reported-by: syzbot+afb980676c836b4a0afa@...kaller.appspotmail.com > Signed-off-by: Jeremy Sowden <jeremy@...zel.net> Applied and queued up for -stable.
Powered by blists - more mailing lists