netdev - Re: [RFC net-next 1/2] net: sched: refactor reinsert action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Jun 2019 19:43:53 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     John Hurley <john.hurley@...ronome.com>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <fw@...len.de>, <jhs@...atatu.com>,
        <simon.horman@...ronome.com>, <jakub.kicinski@...ronome.com>,
        <oss-drivers@...ronome.com>
Subject: Re: [RFC net-next 1/2] net: sched: refactor reinsert action

On 14/06/2019 15:33, John Hurley wrote:
> Instead of
> returning TC_ACT_REINSERT, change the type to the new TC_ACT_CONSUMED
> which tells the caller that the packet has been stolen by another process
> and that no consume call is required.
Possibly a dumb question, but why does this need a new CONSUMED rather
 than, say, taking an additional ref and returning TC_ACT_STOLEN?

Apart from that, the series lgtm.

-Ed