netdev - Re: [PATCH net-next 02/17] netlink: Add field to skip in-kernel notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4ff39a6-9604-6c3c-bf2b-a2c36471e84d@gmail.com>
Date:   Sun, 16 Jun 2019 19:17:26 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, jiri@...lanox.com, alexpe@...lanox.com,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 02/17] netlink: Add field to skip in-kernel
 notifications

On 6/15/19 8:07 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...lanox.com>
> 
> The struct includes a 'skip_notify' flag that indicates if netlink
> notifications to user space should be suppressed. As explained in commit
> 3b1137fe7482 ("net: ipv6: Change notifications for multipath add to
> RTA_MULTIPATH"), this is useful to suppress per-nexthop RTM_NEWROUTE
> notifications when an IPv6 multipath route is added / deleted. Instead,
> one notification is sent for the entire multipath route.
> 
> This concept is also useful for in-kernel notifications. Sending one
> in-kernel notification for the addition / deletion of an IPv6 multipath
> route - instead of one per-nexthop - provides a significant increase in
> the insertion / deletion rate to underlying devices.
> 
> Add a 'skip_notify_kernel' flag to suppress in-kernel notifications.
> 
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  include/net/netlink.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Unfortunate a second flag is needed.

Reviewed-by: David Ahern <dsahern@...il.com>