netdev - Re: [patch net-next] net: sched: cls_matchall: allow to delete filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190617.140639.2221973922220817249.davem@davemloft.net>
Date:   Mon, 17 Jun 2019 14:06:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, mlxsw@...lanox.com, eli@...lanox.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com
Subject: Re: [patch net-next] net: sched: cls_matchall: allow to delete
 filter

From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 17 Jun 2019 18:02:32 +0200

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Currently user is unable to delete the filter. See following example:
> $ tc filter add dev ens16np1 ingress pref 1 handle 1 matchall action drop
> $ tc filter show dev ens16np1 ingress
> filter protocol all pref 1 matchall chain 0
> filter protocol all pref 1 matchall chain 0 handle 0x1
>   in_hw
>         action order 1: gact action drop
>          random type none pass val 0
>          index 1 ref 1 bind 1
> 
> $ tc filter del dev ens16np1 ingress pref 1 handle 1 matchall action drop
> RTNETLINK answers: Operation not supported
> 
> Implement tcf_proto_ops->delete() op and allow user to delete the filter.
> 
> Reported-by: Eli Cohen <eli@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied, thanks.