netdev - Re: [PATCH net-next 4/4] qed: Add devlink support for configuration attributes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190617155411.53cf07cf@cakuba.netronome.com>
Date:   Mon, 17 Jun 2019 15:54:11 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Sudarsana Reddy Kalluru <skalluru@...vell.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <mkalderon@...vell.com>, <aelior@...vell.com>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next 4/4] qed: Add devlink support for configuration
 attributes.

On Mon, 17 Jun 2019 04:45:28 -0700, Sudarsana Reddy Kalluru wrote:
> This patch adds implementation for devlink callbacks for reading/
> configuring the device attributes.
> 
> Signed-off-by: Sudarsana Reddy Kalluru <skalluru@...vell.com>
> Signed-off-by: Ariel Elior <aelior@...vell.com>

You need to provide documentation for your parameters, plus some of
them look like they should potentially be port params, not device
params.