netdev - Re: [PATCH net-next v3 4/6] taprio: Add support for txtime-assist mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190617.162245.717911211395007022.davem@davemloft.net>
Date:   Mon, 17 Jun 2019 16:22:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vedang.patel@...el.com
Cc:     netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        intel-wired-lan@...ts.osuosl.org, vinicius.gomes@...el.com,
        l@...ileo.org
Subject: Re: [PATCH net-next v3 4/6] taprio: Add support for txtime-assist
 mode.

From: Vedang Patel <vedang.patel@...el.com>
Date: Mon, 17 Jun 2019 12:31:08 -0700

> diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
> index a41d7d4434ee..ab6080013666 100644
> --- a/net/sched/sch_taprio.c
> +++ b/net/sched/sch_taprio.c
 ...
> +/* Get how much time has been already elapsed in the current cycle. */
> +static inline s32 get_cycle_time_elapsed(struct sched_gate_list *sched, ktime_t time)
> +{

Please do not use the inline directive in foo.c files, let the compiler decide.

 ...
> +static inline int length_to_duration(struct taprio_sched *q, int len)
> +{
> +	return (len * atomic64_read(&q->picos_per_byte)) / 1000;
> +}

Likewise.

 ...
> +static inline ktime_t get_cycle_start(struct sched_gate_list *sched,
> +				      ktime_t time)
> +{

Likewise.