netdev - Re: [PATCH ipsec-next] xfrm: fix bogus WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Jun 2019 11:20:20 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Florian Westphal <fw@...len.de>
CC:     <netdev@...r.kernel.org>, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH ipsec-next] xfrm: fix bogus WARN_ON with ipv6

On Wed, Jun 12, 2019 at 10:30:58AM +0200, Florian Westphal wrote:
> net/xfrm/xfrm_input.c:378:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
> skb->protocol = htons(ETH_P_IPV6);
> 
> ... the fallthrough then causes a bogus WARN_ON().
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Fixes: 4c203b0454b ("xfrm: remove eth_proto value from xfrm_state_afinfo")
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks Florian!