netdev - Re: [PATCH net-next] mlxsw: spectrum_ptp: Fix compilation on 32-bit ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jun 2019 08:56:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     shalomt@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, idosch@...lanox.com,
        mlxsw@...lanox.com, natechancellor@...il.com
Subject: Re: [PATCH net-next] mlxsw: spectrum_ptp: Fix compilation on
 32-bit ARM

From: Shalom Toledo <shalomt@...lanox.com>
Date: Tue, 18 Jun 2019 12:45:35 +0000

> Compilation on 32-bit ARM fails after commit 992aa864dca0 ("mlxsw:
> spectrum_ptp: Add implementation for physical hardware clock operations")
> because of 64-bit division:
> 
> arm-linux-gnueabi-ld:
> drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.o: in function
> `mlxsw_sp1_ptp_phc_settime': spectrum_ptp.c:(.text+0x39c): undefined
> reference to `__aeabi_uldivmod'
> 
> Fix by using div_u64().
> 
> Fixes: 992aa864dca0 ("mlxsw: spectrum_ptp: Add implementation for physical hardware clock operations")
> Signed-off-by: Shalom Toledo <shalomt@...lanox.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: Nathan Chancellor <natechancellor@...il.com>

Applied, thank you.