netdev - Re: [PATCH 7/8] net: ethernet: ixp4xx: Add DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbkwTtS2ofpxkZLERW-b+4=d7m9qiPXGT+iMemn9zZE1A@mail.gmail.com>
Date:   Tue, 18 Jun 2019 21:44:21 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Krzysztof Halasa <khalasa@...p.pl>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 7/8] net: ethernet: ixp4xx: Add DT bindings

On Fri, May 24, 2019 at 9:41 PM Rob Herring <robh@...nel.org> wrote:

> > +  reg:
> > +    maxItems: 1
> > +    description: Ethernet MMIO address range
> > +
> > +  queue-rx:
> > +    $ref: '/schemas/types.yaml#/definitions/phandle-array'
> > +    maxItems: 1
>
> This doesn't actually do what you think it is doing. A $ref plus
> additional constraints need to be under an 'allOf' list.
>
> > +    description: phandle to the RX queue on the NPE
>
> But this is a phandle plus 1 cell, right?
>
> - allOf:
>     - $ref: '/schemas/types.yaml#/definitions/phandle-array'
>     - items:
>         - items:
>             - description: phandle to the RX queue on the NPE
>             - description: whatever the cell contains
>               enum: [ 1, 2, 3, 4 ] # any constraints you can put on the cell
>
> This implicitly says you have 1 of a phandle + 1 cell.
>
> I need to add this to example-schema.yaml...

I just can't get this right :(

I have this:

  queue-rx:
    - allOf:
      - $ref: '/schemas/types.yaml#/definitions/phandle-array'
      - items:
        - items:
          - description: phandle to the RX queue on the NPE
          - description: index of the NPE engine RX queue to use
            enum: [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]

I get this from dt_binding_check:

  CHKDT   Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml
Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml:
properties:queue-rx: [{'allOf': [{'$ref':
'/schemas/types.yaml#/definitions/phandle-array'}, {'items':
[{'items': [{'description': 'phandle to the RX queue on the NPE'},
{'description': 'index of the NPE engine RX queue to use', 'enum': [0,
1, 2, 3, 4, 5, 6, 7, 8, 9, 10]}]}]}]}] is not of type 'object',
'boolean'
make[3]: *** [../Documentation/devicetree/bindings/Makefile:12:
Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.example.dts]
Error 1

Hm .... I just can't figure out what this recursive parsing thingie means...
I tried to update the pip3 repo but no cigar.

Any hints?

Yours,
Linus Walleij