netdev - Re: [net-next, PATCH 1/2, v2] net: netsec: initialize tx ring on ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190619.102856.1934195744157627483.davem@davemloft.net>
Date:   Wed, 19 Jun 2019 10:28:56 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ilias.apalodimas@...aro.org
Cc:     jaswinder.singh@...aro.org, netdev@...r.kernel.org,
        ard.biesheuvel@...aro.org, masahisa.kojima@...aro.org
Subject: Re: [net-next, PATCH 1/2, v2] net: netsec: initialize tx ring on
 ndo_open

From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
Date: Wed, 19 Jun 2019 13:04:00 +0300

> Since we changed the Tx ring handling and now depends on bit31 to figure
> out the owner of the descriptor, we should initialize this every time
> the device goes down-up instead of doing it once on driver init. If the
> value is not correctly initialized the device won't have any available
> descriptors
> 
> Changes since v1:
> - Typo fixes
> 
> Fixes: 35e07d234739 ("net: socionext: remove mmio reads on Tx")
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

Applied, please do not put an empty line between the Fixes and other
tags.  Keep all the tags together in one group.

Thanks.