lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Jun 2019 12:07:26 -0400 (EDT) From: David Miller <davem@...emloft.net> To: tracywwnj@...il.com Cc: netdev@...r.kernel.org, kafai@...com, edumazet@...gle.com, maheshb@...gle.com, dsahern@...il.com, weiwan@...gle.com Subject: Re: [PATCH net-next 3/5] ipv6: honor RT6_LOOKUP_F_DST_NOREF in rule lookup logic From: Wei Wang <tracywwnj@...il.com> Date: Tue, 18 Jun 2019 11:25:41 -0700 > @@ -237,13 +240,16 @@ static int __fib6_rule_action(struct fib_rule *rule, struct flowi *flp, > goto out; > } > again: > - ip6_rt_put(rt); > + if (!(flags & RT6_LOOKUP_F_DST_NOREF) || > + !list_empty(&rt->rt6i_uncached)) > + ip6_rt_put(rt); This conditional release logic, with the special treatment of uncache items when using DST_NOREF, seems error prone. Maybe you can put this logic into a helper like ip6_rt_put_any() and do the list empty test etc. there? ip6_rt_put_any(struct rt6_info *rt, int flags); What do you think?
Powered by blists - more mailing lists