netdev - Re: [PATCH][bpf] bpf: verifier: add break statement in switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzY+1-G4Kn1NNEX7iy51rcC4-yV-XWjAdaRTMH-6i-LB3g@mail.gmail.com>
Date:   Wed, 19 Jun 2019 10:43:26 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Lawrence Brakmo <brakmo@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH][bpf] bpf: verifier: add break statement in switch

On Wed, Jun 19, 2019 at 9:02 AM Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
>
> Notice that in this case, it's much clearer to explicitly add a break
> rather than letting the code to fall through. It also avoid potential
> future fall-through warnings[1].
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> [1] https://lore.kernel.org/patchwork/patch/1087056/
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---

Acked-by: Andrii Nakryiko <andriin@...com>

>  kernel/bpf/verifier.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index d2c8a6677ac4..0acf7c569ec6 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -5365,6 +5365,7 @@ static int check_return_code(struct bpf_verifier_env *env)
>                 if (env->prog->expected_attach_type == BPF_CGROUP_UDP4_RECVMSG ||
>                     env->prog->expected_attach_type == BPF_CGROUP_UDP6_RECVMSG)
>                         range = tnum_range(1, 1);
> +               break;
>         case BPF_PROG_TYPE_CGROUP_SKB:
>         case BPF_PROG_TYPE_CGROUP_SOCK:
>         case BPF_PROG_TYPE_SOCK_OPS:
> --
> 2.21.0
>