netdev - Re: [PATCH][bpf-next] bpf: verifier: add a break statement in switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac7c8305-efc5-ffb6-f8a2-9595b2e06197@embeddedor.com>
Date:   Wed, 19 Jun 2019 13:46:05 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Lawrence Brakmo <brakmo@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH][bpf-next] bpf: verifier: add a break statement in switch



On 6/19/19 12:44 PM, Andrii Nakryiko wrote:
> On Wed, Jun 19, 2019 at 9:07 AM Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>>
>> Notice that in this case, it's much clearer to explicitly add a break
>> rather than letting the code to fall through. It also avoid potential
>> future fall-through warnings[1].
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> [1] https://lore.kernel.org/patchwork/patch/1087056/
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
> 
> Acked-by: Andrii Nakryiko <andriin@...com>
> 

Thanks, Andrii.

--
Gustavo