netdev - Re: [PATCH net-next] ipv6: Check if route exists before notifying it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69f3262d-e6d0-943e-20a0-c711be4d35d7@gmail.com>
Date:   Wed, 19 Jun 2019 13:10:08 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, mlxsw@...lanox.com,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next] ipv6: Check if route exists before notifying it

On 6/19/19 11:55 AM, Ido Schimmel wrote:
> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
> index 1d16a01eccf5..241a0e9a07c3 100644
> --- a/net/ipv6/ip6_fib.c
> +++ b/net/ipv6/ip6_fib.c
> @@ -393,6 +393,8 @@ int call_fib6_multipath_entry_notifiers(struct net *net,
>  		.nsiblings = nsiblings,
>  	};
>  
> +	if (!rt)
> +		return -EINVAL;
>  	rt->fib6_table->fib_seq++;
>  	return call_fib6_notifiers(net, event_type, &info.info);
>  }

The call to call_fib6_multipath_entry_notifiers in
ip6_route_multipath_add happens without rt_notif set because the MPATH
spec is empty? It seems like that check should be done in
ip6_route_multipath_add rather than call_fib6_multipath_entry_notifiers
with an extack saying the reason for the failure.

My expectation for call_fib6_multipath_entry_notifiers is any errors are
only for offload handlers. (And we need to get extack added to that for
relaying reasons.)