netdev - [PATCH v4 0/1] net: fastopen: follow-up tweaks for SipHash switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190619214628.2960-1-ard.biesheuvel@linaro.org>
Date:   Wed, 19 Jun 2019 23:46:27 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     netdev@...r.kernel.org
Cc:     Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Eric Biggers <ebiggers@...nel.org>,
        linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au,
        edumazet@...gle.com, davem@...emloft.net, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, jbaron@...mai.com, cpaasch@...le.com,
        David.Laight@...lab.com, ycheng@...gle.com
Subject: [PATCH v4 0/1] net: fastopen: follow-up tweaks for SipHash switch

Some fixes for the fastopen code after switching to SipHash, which were
spotted in review after the change had already been queued.

Changes since v3:
- switch from compount literals to individual assignments of the siphash
  key fields

Changes since v2:
- add missing pairs of braces in compound literals used to assign the
  fastopen keys

cc: Eric Biggers <ebiggers@...nel.org>
cc: linux-crypto@...r.kernel.org
cc: herbert@...dor.apana.org.au
cc: edumazet@...gle.com
cc: davem@...emloft.net
cc: kuznet@....inr.ac.ru
cc: yoshfuji@...ux-ipv6.org
cc: jbaron@...mai.com
cc: cpaasch@...le.com
cc: David.Laight@...lab.com
cc: ycheng@...gle.com

Ard Biesheuvel (1):
  net: fastopen: robustness and endianness fixes for SipHash

 include/linux/tcp.h        |  2 +-
 include/net/tcp.h          |  8 ++---
 net/ipv4/sysctl_net_ipv4.c |  3 +-
 net/ipv4/tcp.c             |  3 +-
 net/ipv4/tcp_fastopen.c    | 35 ++++++++++----------
 5 files changed, 24 insertions(+), 27 deletions(-)

-- 
2.17.1