lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Jun 2019 23:13:15 +0000 From: "Bowers, AndrewX" <andrewx.bowers@...el.com> To: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [Intel-wired-lan] [PATCH][next][V2] ixgbe: fix potential u32 overflow on shift > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...osl.org] On > Behalf Of Colin King > Sent: Friday, June 7, 2019 11:19 AM > To: Keller, Jacob E <jacob.e.keller@...el.com>; Kirsher, Jeffrey T > <jeffrey.t.kirsher@...el.com>; David S . Miller <davem@...emloft.net>; > intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org > Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org > Subject: [Intel-wired-lan] [PATCH][next][V2] ixgbe: fix potential u32 > overflow on shift > > From: Colin Ian King <colin.king@...onical.com> > > The u32 variable rem is being shifted using u32 arithmetic however it is being > passed to div_u64 that expects the expression to be a u64. > The 32 bit shift may potentially overflow, so cast rem to a u64 before shifting > to avoid this. Also remove comment about overflow. > > Addresses-Coverity: ("Unintentional integer overflow") > Fixes: cd4583206990 ("ixgbe: implement support for SDP/PPS output on X550 > hardware") > Fixes: 68d9676fc04e ("ixgbe: fix PTP SDP pin setup on X540 hardware") > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > > V2: update comment > > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
Powered by blists - more mailing lists