netdev - Re: [PATCH v2 net-next 5/5] ipv6: convert major tx path to use RT6_LOOKUP_F_DST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEA6p_DMFdBeC_RZ6sgBt1NXxWN1fdBzCtSoR+K3nRtDrLuOJg@mail.gmail.com>
Date:   Wed, 19 Jun 2019 16:28:56 -0700
From:   Wei Wang <weiwan@...gle.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Wei Wang <tracywwnj@...il.com>, David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Mahesh Bandewar <maheshb@...gle.com>,
        Martin KaFai Lau <kafai@...com>
Subject: Re: [PATCH v2 net-next 5/5] ipv6: convert major tx path to use RT6_LOOKUP_F_DST_NOREF

On Wed, Jun 19, 2019 at 4:21 PM David Ahern <dsahern@...il.com> wrote:
>
> On 6/19/19 4:31 PM, Wei Wang wrote:
> > diff --git a/include/net/l3mdev.h b/include/net/l3mdev.h
> > index e942372b077b..d8c37317bb86 100644
> > --- a/include/net/l3mdev.h
> > +++ b/include/net/l3mdev.h
> > @@ -31,8 +31,9 @@ struct l3mdev_ops {
> >                                         u16 proto);
> >
> >       /* IPv6 ops */
> > -     struct dst_entry * (*l3mdev_link_scope_lookup)(const struct net_device *dev,
> > -                                              struct flowi6 *fl6);
> > +     struct dst_entry * (*l3mdev_link_scope_lookup_noref)(
> > +                                         const struct net_device *dev,
> > +                                         struct flowi6 *fl6);
>
> I would prefer to add a comment about not taking a references vs adding
> the _noref extension. There is only 1 user for 1 context and the name
> length is getting out of hand (as evidenced by the line wrapping below).

Hmm OK. I was trying to make it clear to make sure future callers do
not misuse it.