netdev - Re: [PATCH bpf] samples/bpf: xdp_redirect, correctly get dummy program id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87muic8o6g.fsf@toke.dk>
Date:   Thu, 20 Jun 2019 07:57:11 -0400
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Prashant Bhole <prashantbhole.linux@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Cc:     Prashant Bhole <prashantbhole.linux@...il.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf] samples/bpf: xdp_redirect, correctly get dummy program id

Prashant Bhole <prashantbhole.linux@...il.com> writes:

> When we terminate xdp_redirect, it ends up with following message:
> "Program on iface OUT changed, not removing"
> This results in dummy prog still attached to OUT interface.
> It is because signal handler checks if the programs are the same that
> we had attached. But while fetching dummy_prog_id, current code uses
> prog_fd instead of dummy_prog_fd. This patch passes the correct fd.
>
> Fixes: 3b7a8ec2dec3 ("samples/bpf: Check the prog id before exiting")
> Signed-off-by: Prashant Bhole <prashantbhole.linux@...il.com>

Huh, I seem to recall fixing this for the other example program, but
guess I missed this one.

Acked-by: Toke Høiland-Jørgensen <toke@...hat.com>