lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Jun 2019 21:02:26 +0200 From: Stefano Brivio <sbrivio@...hat.com> To: David Ahern <dsahern@...il.com> Cc: David Miller <davem@...emloft.net>, Jianlin Shi <jishi@...hat.com>, Wei Wang <weiwan@...gle.com>, Martin KaFai Lau <kafai@...com>, Eric Dumazet <edumazet@...gle.com>, Matti Vaittinen <matti.vaittinen@...rohmeurope.com>, netdev@...r.kernel.org Subject: Re: [PATCH net-next v6 08/11] ipv6: Dump route exceptions if requested On Thu, 20 Jun 2019 08:24:22 -0600 David Ahern <dsahern@...il.com> wrote: > On 6/19/19 5:59 PM, Stefano Brivio wrote: > > + if (filter->dump_exceptions) { > > + struct fib6_nh_exception_dump_walker w = { .dump = arg, > > + .rt = rt, > > + .flags = flags, > > + .skip = skip, > > + .count = 0 }; > > + int err; > > + > > + if (rt->nh) { > > + err = nexthop_for_each_fib6_nh(rt->nh, > > + rt6_nh_dump_exceptions, > > + &w); > > much like ipv4, the skb can fill in the middle of a fib6_nh bucket, so > you need to track which nexthop is in progress. Same as my comment about IPv4, except that, for IPv6, distinction between skip and skip_in_node is strictly needed, but buckets and nexthops are traversed in the same order and 'sernum' changes don't affect that. -- Stefano
Powered by blists - more mailing lists