netdev - Re: [PATCH v4 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Jun 2019 20:49:28 +0530
From:   Puranjay Mohan <puranjay12@...il.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     Puranjay Mohan <puranjay12@...il.com>,
        Bjorn Helgaas <bjorn@...gaas.com>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-pci@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH v4 0/3] net: fddi: skfp: Use PCI generic definitions
 instead of private duplicates

On Fri, Jun 21, 2019 at 08:44:12PM +0530, Puranjay Mohan wrote:
> This patch series removes the private duplicates of PCI definitions in
> favour of generic definitions defined in pci_regs.h.
> 
> This driver only uses some of the generic PCI definitons,
> which are included from pci_regs.h and thier private versions
> are removed from skfbi.h with all other private defines.
> 
> The skfbi.h defines PCI_REV_ID and other private defines with different
> names, these are renamed to Generic PCI names to make them
> compatible with defines in pci_regs.h.
> 
> All unused defines are removed from skfbi.h.
>
I left some of the definitions in v4 too!
will remove them all and send v5
sorry for the inconvenience
> Changes in v4:
> Removed unused PCI definitions which were left in v3
> 
> Changes in v3:
> Renamed all local PCI definitions to Generic names.
> Corrected coding style mistakes.
> 
> Changes in v2:
> Converted individual patches to a series.
> Made sure that individual patches build correctly
> 
> Puranjay Mohan (3):
>   net: fddi: skfp: Rename local PCI defines to match generic PCI defines
>   net: fddi: skfp: Include generic PCI definitions
>   net: fddi: skfp: Remove unused private PCI definitions
> 
>  drivers/net/fddi/skfp/drvfbi.c  |   3 +-
>  drivers/net/fddi/skfp/h/skfbi.h | 217 +-------------------------------
>  2 files changed, 6 insertions(+), 214 deletions(-)
> 
> -- 
> 2.21.0
>