netdev - Re: [PATCH net-next] netfilter: ipv6: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cceb80d8-8997-5831-cb39-14801c1cfe39@huawei.com>
Date:   Fri, 21 Jun 2019 10:05:37 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
CC:     <kadlec@...ckhole.kfki.hu>, <fw@...len.de>, <davem@...emloft.net>,
        <rdunlap@...radead.org>, <linux-kernel@...r.kernel.org>,
        <coreteam@...filter.org>, <netfilter-devel@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] netfilter: ipv6: Fix build error without
 CONFIG_IPV6

On 2019/6/20 23:50, Pablo Neira Ayuso wrote:
> On Thu, Jun 20, 2019 at 11:26:01PM +0800, Yuehaibing wrote:
>> Friendly ping...
>>
>> On 2019/6/12 16:47, YueHaibing wrote:
>>> If CONFIG_IPV6 is not set, building fails:
>>>
>>> net/bridge/netfilter/nf_conntrack_bridge.o: In function `nf_ct_bridge_pre':
>>> nf_conntrack_bridge.c:(.text+0x41c): undefined symbol `nf_ct_frag6_gather'
>>> net/bridge/netfilter/nf_conntrack_bridge.o: In function `nf_ct_bridge_post':
>>> nf_conntrack_bridge.c:(.text+0x820): undefined symbol `br_ip6_fragment'
> 
> Is this one enough to fix this problem?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/?id=16e6427c88c5b7e7b6612f6c286d5f71d659e5be

No, building the linux-next for 20190620 still fails with this patch

The randconfig attached.

>  
> Thanks.
> 
>>> Reported-by: Hulk Robot <hulkci@...wei.com>
>>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
>>> Fixes: c9bb6165a16e ("netfilter: nf_conntrack_bridge: fix CONFIG_IPV6=y")
>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>>> ---
>>>  include/linux/netfilter_ipv6.h | 10 ++++++++--
>>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/linux/netfilter_ipv6.h b/include/linux/netfilter_ipv6.h
>>> index 3a3dc4b..0e1febc 100644
>>> --- a/include/linux/netfilter_ipv6.h
>>> +++ b/include/linux/netfilter_ipv6.h
>>> @@ -108,8 +108,11 @@ static inline int nf_ipv6_br_defrag(struct net *net, struct sk_buff *skb,
>>>  		return 1;
>>>  
>>>  	return v6_ops->br_defrag(net, skb, user);
>>> -#else
>>> +#endif
>>> +#if IS_BUILTIN(CONFIG_IPV6)
>>>  	return nf_ct_frag6_gather(net, skb, user);
>>> +#else
>>> +	return 1;
>>>  #endif
>>>  }
>>>  
>>> @@ -133,8 +136,11 @@ static inline int nf_br_ip6_fragment(struct net *net, struct sock *sk,
>>>  		return 1;
>>>  
>>>  	return v6_ops->br_fragment(net, sk, skb, data, output);
>>> -#else
>>> +#endif
>>> +#if IS_BUILTIN(CONFIG_IPV6)
>>>  	return br_ip6_fragment(net, sk, skb, data, output);
>>> +#else
>>> +	return 1;
>>>  #endif
>>>  }
>>>  
>>>
>>
> 
> .
> 

View attachment "config" of type "text/plain" (173492 bytes)