netdev - Re: [PATCH] sis900: fix TX completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190622.164700.475498860884895501.davem@davemloft.net>
Date:   Sat, 22 Jun 2019 16:47:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sergej.benilov@...glemail.com
Cc:     venza@...wnhat.org, netdev@...r.kernel.org
Subject: Re: [PATCH] sis900: fix TX completion

From: Sergej Benilov <sergej.benilov@...glemail.com>
Date: Thu, 20 Jun 2019 11:02:18 +0200

> Since commit 605ad7f184b60cfaacbc038aa6c55ee68dee3c89 "tcp: refine TSO autosizing",
> outbound throughput is dramatically reduced for some connections, as sis900
> is doing TX completion within idle states only.
> 
> Make TX completion happen after every transmitted packet.
> 
> Test:
> netperf
> 
> before patch:
>> netperf -H remote -l -2000000 -- -s 1000000
> MIGRATED TCP STREAM TEST from 0.0.0.0 () port 0 AF_INET to 95.223.112.76 () port 0 AF_INET : demo
> Recv   Send    Send
> Socket Socket  Message  Elapsed
> Size   Size    Size     Time     Throughput
> bytes  bytes   bytes    secs.    10^6bits/sec
> 
>  87380 327680 327680    253.44      0.06
> 
> after patch:
>> netperf -H remote -l -10000000 -- -s 1000000
> MIGRATED TCP STREAM TEST from 0.0.0.0 () port 0 AF_INET to 95.223.112.76 () port 0 AF_INET : demo
> Recv   Send    Send
> Socket Socket  Message  Elapsed
> Size   Size    Size     Time     Throughput
> bytes  bytes   bytes    secs.    10^6bits/sec
> 
>  87380 327680 327680    5.38       14.89
> 
> Thx to Dave Miller and Eric Dumazet for helpful hints
> 
> Signed-off-by: Sergej Benilov <sergej.benilov@...glemail.com>

Applied.