lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Jun 2019 11:08:24 +0100 From: Russell King - ARM Linux admin <linux@...linux.org.uk> To: Parshuram Thombare <pthombar@...ence.com> Cc: andrew@...n.ch, nicolas.ferre@...rochip.com, davem@...emloft.net, f.fainelli@...il.com, netdev@...r.kernel.org, hkallweit1@...il.com, linux-kernel@...r.kernel.org, rafalc@...ence.com, aniljoy@...ence.com, piotrs@...ence.com Subject: Re: [PATCH v4 1/5] net: macb: add phylink support On Sun, Jun 23, 2019 at 10:17:37AM +0100, Parshuram Thombare wrote: > + switch (state->interface) { > + case PHY_INTERFACE_MODE_GMII: > + case PHY_INTERFACE_MODE_RGMII: > + if (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE) { > + phylink_set(mask, 1000baseT_Full); > + phylink_set(mask, 1000baseX_Full); > + if (!(bp->caps & MACB_CAPS_NO_GIGABIT_HALF)) { > + phylink_set(mask, 1000baseT_Half); > + phylink_set(mask, 1000baseT_Half); I think this can be cleaned up. > + } > + } > + /* fallthrough */ > + case PHY_INTERFACE_MODE_MII: > + case PHY_INTERFACE_MODE_RMII: > + phylink_set(mask, 10baseT_Half); > + phylink_set(mask, 10baseT_Full); > + phylink_set(mask, 100baseT_Half); > + phylink_set(mask, 100baseT_Full); > + break; > + default: > + break; > + } > > - spin_lock_irqsave(&bp->lock, flags); > + linkmode_and(supported, supported, mask); > + linkmode_and(state->advertising, state->advertising, mask); > You remove this blank line in the next patch, so given that this is a new function, you might as well clean that up in this patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
Powered by blists - more mailing lists