netdev - Re: [PATCH V1 net-next] net: ena: Fix bug where ring allocation backoff stopped too late

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 23 Jun 2019 08:39:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sameehj@...zon.com
Cc:     netdev@...r.kernel.org, dwmw@...zon.com, zorik@...zon.com,
        matua@...zon.com, saeedb@...zon.com, msw@...zon.com,
        aliguori@...zon.com, nafea@...zon.com, gtzalik@...zon.com,
        netanel@...zon.com, alisaidi@...zon.com, benh@...zon.com,
        akiyano@...zon.com
Subject: Re: [PATCH V1 net-next] net: ena: Fix bug where ring allocation
 backoff stopped too late

From: <sameehj@...zon.com>
Date: Sun, 23 Jun 2019 10:11:10 +0300

> From: Sameeh Jubran <sameehj@...zon.com>
> 
> The current code of create_queues_with_size_backoff() allows the ring size
> to become as small as ENA_MIN_RING_SIZE/2. This is a bug since we don't
> want the queue ring to be smaller than ENA_MIN_RING_SIZE
> 
> In this commit we change the loop's termination condition to look at the
> queue size of the next iteration instead of that of the current one,
> so that the minimal queue size again becomes ENA_MIN_RING_SIZE.
> 
> Fixes: eece4d2ab9d2 ("net: ena: add ethtool function for changing io queue sizes")
> 
> Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com>
> Signed-off-by: Sameeh Jubran <sameehj@...zon.com>

Applied, thank you.