netdev - Re: [PATCH net-next 10/16] qlge: Factor out duplicated expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Jun 2019 11:00:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bpoirier@...e.com
Cc:     manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 10/16] qlge: Factor out duplicated expression

From: David Miller <davem@...emloft.net>
Date: Sun, 23 Jun 2019 10:59:35 -0700 (PDT)

> "(u16) 65536" is zero and the range of these values is 0 -- 65536.
> 
> This whole expression is way overdone.

Also, when you post the next revision of this patch series, please
provide a proper "[PATCH net-next 00/16]" header posting explaining
what this patch series does logically at the high level, how it is
doing it, and why it is doing it that way.

Thank you.