netdev - Re: [PATCH][net-next] hinic: fix dereference of pointer hwdev before it is null checked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190623.110835.523516058927476452.davem@davemloft.net>
Date:   Sun, 23 Jun 2019 11:08:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     xuechaojing@...wei.com, aviad.krawczyk@...wei.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][net-next] hinic: fix dereference of pointer hwdev
 before it is null checked

From: Colin King <colin.king@...onical.com>
Date: Thu, 20 Jun 2019 14:27:51 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently pointer hwdev is dereferenced when assigning hwif before
> hwdev is null checked.  Fix this by only derefencing hwdev after the
> null check.
> 
> Addresses-Coverity: ("Dereference before null check")
> Fixes: 4fdc51bb4e92 ("hinic: add support for rss parameters with ethtool")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.