netdev - Re: [PATCH net-next v2 3/3] mlxsw: core: Add support for negative temperature readout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190624114201.GB5167@nanopsycho>
Date:   Mon, 24 Jun 2019 13:42:01 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        vadimp@...lanox.com, andrew@...n.ch, mlxsw@...lanox.com,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next v2 3/3] mlxsw: core: Add support for negative
 temperature readout

Mon, Jun 24, 2019 at 12:32:03PM CEST, idosch@...sch.org wrote:
>From: Vadim Pasternak <vadimp@...lanox.com>
>
>Extend macros MLXSW_REG_MTMP_TEMP_TO_MC() to allow support of negative
>temperature readout, since chip and others thermal components are
>capable of operating within the negative temperature.
>With no such support negative temperature will be consider as very high
>temperature and it will cause wrong readout and thermal shutdown.
>For negative values 2`s complement is used.
>Tested in chamber.
>Example of chip ambient temperature readout with chamber temperature:
>-10 Celsius:
>temp1:             -6.0C  (highest =  -5.0C)
>-5 Celsius:
>temp1:             -1.0C  (highest =  -1.0C)
>
>v2 (Andrew Lunn):
>* Replace '%u' with '%d' in mlxsw_hwmon_module_temp_show()
>
>Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
>Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>