lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Jun 2019 16:36:44 +0300 From: Yishai Hadas <yishaih@....mellanox.co.il> To: Jason Gunthorpe <jgg@...lanox.com> Cc: Leon Romanovsky <leon@...nel.org>, Doug Ledford <dledford@...hat.com>, Leon Romanovsky <leonro@...lanox.com>, RDMA mailing list <linux-rdma@...r.kernel.org>, Yishai Hadas <yishaih@...lanox.com>, Saeed Mahameed <saeedm@...lanox.com>, linux-netdev <netdev@...r.kernel.org> Subject: Re: [PATCH rdma-next v1 09/12] IB/mlx5: Register DEVX with mlx5_core to get async events On 6/24/2019 2:52 PM, Jason Gunthorpe wrote: > On Tue, Jun 18, 2019 at 08:15:37PM +0300, Leon Romanovsky wrote: >> void __mlx5_ib_remove(struct mlx5_ib_dev *dev, >> diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h >> index 9cf23ae6324e..556af34b788b 100644 >> +++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h >> @@ -944,6 +944,13 @@ struct mlx5_ib_pf_eq { >> mempool_t *pool; >> }; >> >> +struct mlx5_devx_event_table { >> + struct mlx5_nb devx_nb; >> + /* serialize updating the event_xa */ >> + struct mutex event_xa_lock; >> + struct xarray event_xa; >> +}; >> + >> struct mlx5_ib_dev { >> struct ib_device ib_dev; >> struct mlx5_core_dev *mdev; >> @@ -994,6 +1001,7 @@ struct mlx5_ib_dev { >> struct mlx5_srq_table srq_table; >> struct mlx5_async_ctx async_ctx; >> int free_port; >> + struct mlx5_devx_event_table devx_event_table; > > I really question if adding all these structs really does anything for > readability.. > I would prefer this option to add only one structure (i.e. mlx5_devx_event_table) on ib_dev, it will hold internally the other related stuff.
Powered by blists - more mailing lists