netdev - Re: [PATCH net] net/tls: fix page double free on TX cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190624.072134.1587556039627335168.davem@davemloft.net>
Date:   Mon, 24 Jun 2019 07:21:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        john.fastabend@...il.com, vakul.garg@....com, borisp@...lanox.com,
        alexei.starovoitov@...il.com, dirk.vandermerwe@...ronome.com
Subject: Re: [PATCH net] net/tls: fix page double free on TX cleanup

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Sun, 23 Jun 2019 21:26:58 -0700

> From: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> 
> With commit 94850257cf0f ("tls: Fix tls_device handling of partial records")
> a new path was introduced to cleanup partial records during sk_proto_close.
> This path does not handle the SW KTLS tx_list cleanup.
> 
> This is unnecessary though since the free_resources calls for both
> SW and offload paths will cleanup a partial record.
> 
> The visible effect is the following warning, but this bug also causes
> a page double free.
 ...
> Fixes: 94850257cf0f ("tls: Fix tls_device handling of partial records")
> Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied and queued up for -stable, thanks.