netdev - Re: [PATCH v2 net-next 0/4] cxgb4: Reference count MPS TCAM entries within a PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190624.075323.2257534731180163594.davem@davemloft.net>
Date:   Mon, 24 Jun 2019 07:53:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rajur@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com, dt@...lsio.com
Subject: Re: [PATCH v2 net-next 0/4] cxgb4: Reference count MPS TCAM
 entries within a PF

From: David Miller <davem@...emloft.net>
Date: Mon, 24 Jun 2019 07:51:32 -0700 (PDT)

> From: Raju Rangoju <rajur@...lsio.com>
> Date: Mon, 24 Jun 2019 14:20:33 +0530
> 
>> Firmware reference counts the MPS TCAM entries by PF and VF,
>> but it does not do it for usage within a PF or VF. This patch
>> adds the support to track MPS TCAM entries within a PF.
>> 
>> v1->v2:
>>  Use refcount_t type instead of atomic_t for mps reference count
> 
> Series applied, thanks.

Umm, REALLY?!?!?!

drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c: In function ‘cxgb4_mps_ref_dec_by_mac’:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c:17:29: error: passing argument 1 of ‘atomic_dec_and_test’ from incompatible pointer type [-Werror=incompatible-pointer-types]
    if (!atomic_dec_and_test(&mps_entry->refcnt)) {
                             ^~~~~~~~~~~~~~~~~~

You just changed it to a refcount_t and didn't try compiling the
result?

The whole point of refcount_t is that it uses a different set of
interfaces to manipulate the object and you have to therefore
update all the call sites properly.

Reverted...