netdev - Re: [PATCH net] net: macb: do not copy the mac address if NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190624.085758.654339729118496029.davem@davemloft.net>
Date:   Mon, 24 Jun 2019 08:57:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     antoine.tenart@...tlin.com
Cc:     nicolas.ferre@...rochip.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ludovic.desroches@...rochip.com,
        alexandre.belloni@...tlin.com
Subject: Re: [PATCH net] net: macb: do not copy the mac address if NULL

From: Antoine Tenart <antoine.tenart@...tlin.com>
Date: Fri, 21 Jun 2019 17:26:35 +0200

> This patch fixes the MAC address setup in the probe. The MAC address
> retrieved using of_get_mac_address was checked for not containing an
> error, but it may also be NULL which wasn't tested. Fix it by replacing
> IS_ERR with IS_ERR_OR_NULL.
> 
> Fixes: 541ddc66d665 ("net: macb: support of_get_mac_address new ERR_PTR error")
> Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>

Applied, thanks.