netdev - Re: [PATCHv2 net] tipc: check msg->req data len in tipc_nl_compat_bearer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190624.100435.1535171955176516330.davem@davemloft.net>
Date:   Mon, 24 Jun 2019 10:04:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com,
        jon.maloy@...csson.com, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net,
        syzkaller-bugs@...glegroups.com
Subject: Re: [PATCHv2 net] tipc: check msg->req data len in
 tipc_nl_compat_bearer_disable

From: Xin Long <lucien.xin@...il.com>
Date: Tue, 25 Jun 2019 00:28:19 +0800

> This patch is to fix an uninit-value issue, reported by syzbot:
 ...
> TLV_GET_DATA_LEN() may return a negtive int value, which will be
> used as size_t (becoming a big unsigned long) passed into memchr,
> cause this issue.
> 
> Similar to what it does in tipc_nl_compat_bearer_enable(), this
> fix is to return -EINVAL when TLV_GET_DATA_LEN() is negtive in
> tipc_nl_compat_bearer_disable(), as well as in
> tipc_nl_compat_link_stat_dump() and tipc_nl_compat_link_reset_stats().
> 
> v1->v2:
>   - add the missing Fixes tags per Eric's request.
> 
> Fixes: 0762216c0ad2 ("tipc: fix uninit-value in tipc_nl_compat_bearer_enable")
> Fixes: 8b66fee7f8ee ("tipc: fix uninit-value in tipc_nl_compat_link_reset_stats")
> Reported-by: syzbot+30eaa8bf392f7fafffaf@...kaller.appspotmail.com
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks.