netdev - Re: [PATCH net-next 02/18] ionic: Add hardware init and device commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Jun 2019 13:13:04 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 02/18] ionic: Add hardware init and device
 commands

On Fri, 21 Jun 2019 15:22:22 -0700, Shannon Nelson wrote:
> >> +static int identity_show(struct seq_file *seq, void *v)
> >> +{
> >> +	struct ionic *ionic = seq->private;
> >> +	struct identity *ident = &ionic->ident;
> >> +	struct ionic_dev *idev = &ionic->idev;
> >> +
> >> +	seq_printf(seq, "asic_type:        0x%x\n", idev->dev_info.asic_type);
> >> +	seq_printf(seq, "asic_rev:         0x%x\n", idev->dev_info.asic_rev);
> >> +	seq_printf(seq, "serial_num:       %s\n", idev->dev_info.serial_num);
> >> +	seq_printf(seq, "fw_version:       %s\n", idev->dev_info.fw_version);
> >> +	seq_printf(seq, "fw_status:        0x%x\n",
> >> +		   ioread8(&idev->dev_info_regs->fw_status));
> >> +	seq_printf(seq, "fw_heartbeat:     0x%x\n",
> >> +		   ioread32(&idev->dev_info_regs->fw_heartbeat));  
> > devlink just gained a much more flexible version of ethtool -i. Please
> > remove all this and use that.  
> Yes, we intend to add a devlink interface, it just isn't in this first 
> patchset, which is already plenty big.

Please take this out of your patch set, we can't be expected to merge
debugfs implementation of what has proper APIs :/