netdev - Re: [PATCH mlx5-next] net/mlx5: Convert mkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18138852207dfcd26ed512482af2c5ea9de93277.camel@mellanox.com>
Date:   Mon, 24 Jun 2019 22:05:33 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Leon Romanovsky <leonro@...lanox.com>
CC:     Jason Gunthorpe <jgg@...lanox.com>,
        "willy@...radead.org" <willy@...radead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH mlx5-next] net/mlx5: Convert mkey_table to XArray

On Thu, 2019-06-20 at 07:03 +0000, Saeed Mahameed wrote:
> From: Matthew Wilcox <willy@...radead.org>
> 
> The lock protecting the data structure does not need to be an
> rwlock.  The
> only read access to the lock is in an error path, and if that's
> limiting
> your scalability, you have bigger performance problems.
> 
> Eliminate mlx5_mkey_table in favour of using the xarray directly.
> reg_mr_callback must use GFP_ATOMIC for allocating XArray nodes as it
> may
> be called in interrupt context.
> 
> This also fixes a minor bug where SRCU locking was being used on the
> radix
> tree read side, when RCU was needed too.
> 
> Change-Id: Ifeedbbc8f2c856cc044094d03167aae9f9162400
> Signed-off-by: Matthew Wilcox <willy@...radead.org>
> Signed-off-by: Jason Gunthorpe <jgg@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
>  

Applied to mlx5-next.

Thanks,
Saeed.