[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1561414416-29732-1-git-send-email-john.hurley@netronome.com>
Date: Mon, 24 Jun 2019 23:13:34 +0100
From: John Hurley <john.hurley@...ronome.com>
To: netdev@...r.kernel.org
Cc: davem@...emloft.net, fw@...len.de, jhs@...atatu.com,
simon.horman@...ronome.com, jakub.kicinski@...ronome.com,
oss-drivers@...ronome.com, John Hurley <john.hurley@...ronome.com>
Subject: [PATCH net-next 0/2] Track recursive calls in TC act_mirred
These patches aim to prevent act_mirred causing stack overflow events from
recursively calling packet xmit or receive functions. Such events can
occur with poor TC configuration that causes packets to travel in loops
within the system.
Florian Westphal advises that a recursion crash and packets looping are
separate issues and should be treated as such. David Miller futher points
out that pcpu counters cannot track the precise skb context required to
detect loops. Hence these patches are not aimed at detecting packet loops,
rather, preventing stack flows arising from such loops.
John Hurley (2):
net: sched: refactor reinsert action
net: sched: protect against stack overflow in TC act_mirred
include/net/pkt_cls.h | 2 +-
include/net/sch_generic.h | 2 +-
net/core/dev.c | 4 +---
net/sched/act_mirred.c | 17 ++++++++++++++++-
4 files changed, 19 insertions(+), 6 deletions(-)
--
2.7.4
Powered by blists - more mailing lists