netdev - Re: [PATCH V2] net: dsa: microchip: Use gpiod_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda_YOfBYN+CHFQs=ir3R77QHWyCJ_uPH3t7_c-ZbS9HRA@mail.gmail.com>
Date:   Tue, 25 Jun 2019 00:18:59 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Tristram Ha <Tristram.Ha@...rochip.com>,
        Woojung Huh <Woojung.Huh@...rochip.com>
Subject: Re: [PATCH V2] net: dsa: microchip: Use gpiod_set_value_cansleep()

On Sun, Jun 23, 2019 at 5:14 PM Marek Vasut <marex@...x.de> wrote:

> Replace gpiod_set_value() with gpiod_set_value_cansleep(), as the switch
> reset GPIO can be connected to e.g. I2C GPIO expander and it is perfectly
> fine for the kernel to sleep for a bit in ksz_switch_register().
>
> Signed-off-by: Marek Vasut <marex@...x.de>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Tristram Ha <Tristram.Ha@...rochip.com>
> Cc: Woojung Huh <Woojung.Huh@...rochip.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---
> V2: use _cansleep in .remove as well

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij