netdev - Re: [PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d79f013-903b-3305-0379-a272060168ba@6wind.com>
Date:   Tue, 25 Jun 2019 10:49:40 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Lucas Bates <lucasb@...atatu.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, mleitner@...hat.com, vladbu@...lanox.com,
        dcaratti@...hat.com, kernel@...atatu.com
Subject: Re: [PATCH net-next 1/1] tc-testing: Restore original behaviour for
 namespaces in tdc

Le 25/06/2019 à 03:00, Lucas Bates a écrit :
> This patch restores the original behaviour for tdc prior to the
> introduction of the plugin system, where the network namespace
> functionality was split from the main script.
> 
> It introduces the concept of required plugins for testcases,
> and will automatically load any plugin that isn't already
> enabled when said plugin is required by even one testcase.
> 
> Additionally, the -n option for the nsPlugin is deprecated
> so the default action is to make use of the namespaces.
> Instead, we introduce -N to not use them, but still create
> the veth pair.
> 
> buildebpfPlugin's -B option is also deprecated.
> 
> If a test cases requires the features of a specific plugin
> in order to pass, it should instead include a new key/value
> pair describing plugin interactions:
> 
>         "plugins": {
>                 "requires": "buildebpfPlugin"
>         },
> 
> A test case can have more than one required plugin: a list
> can be inserted as the value for 'requires'.
> 
> Signed-off-by: Lucas Bates <lucasb@...atatu.com>

Thank you for the follow up!

Tested-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

[snip]

> @@ -550,6 +614,7 @@ def filter_tests_by_category(args, testlist):
>  
>      return answer
>  
> +
>  def get_test_cases(args):
>      """
>      If a test case file is specified, retrieve tests from that file.
nit: this new line is probably a leftover of a previous version ;-)