netdev - Re: [PATCH net-next] Revert "net: ena: ethtool: add extra properties retrieval via get_priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jun 2019 21:07:15 +0000
From:   "Machulsky, Zorik" <zorik@...zon.com>
To:     David Miller <davem@...emloft.net>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "oss-drivers@...ronome.com" <oss-drivers@...ronome.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "Jubran, Samih" <sameehj@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>
Subject: Re: [PATCH net-next] Revert "net: ena: ethtool: add extra properties
 retrieval via get_priv_flags"

As we agreed during Netconf discussion we'll look into other alternative -  the devlink tool that should potentially answer our needs. 

On 6/25/19, 1:43 PM, "David Miller" <davem@...emloft.net> wrote:

    From: Jakub Kicinski <jakub.kicinski@...ronome.com>
    Date: Tue, 25 Jun 2019 09:59:56 -0700
    
    > This reverts commit 315c28d2b714 ("net: ena: ethtool: add extra properties retrieval via get_priv_flags").
    > 
    > As discussed at netconf and on the mailing list we can't allow
    > for the the abuse of private flags for exposing arbitrary device
    > labels.
    > 
    > Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
    
    Amazon folks I think this is entirely reasonable, please ACK.
    
    Thanks.