netdev - Re: [PATCH 0/1] Fix broken build of mlx5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jun 2019 21:11:15 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "jes.sorensen@...il.com" <jes.sorensen@...il.com>
CC:     "kernel-team@...com" <kernel-team@...com>,
        "jsorensen@...com" <jsorensen@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 0/1] Fix broken build of mlx5

On Tue, 2019-06-25 at 14:01 -0400, Jes Sorensen wrote:
> On 6/25/19 1:54 PM, Saeed Mahameed wrote:
> > On Tue, 2019-06-25 at 11:27 -0400, Jes Sorensen wrote:
> > > From: Jes Sorensen <jsorensen@...com>
> > > 
> > > This fixes an obvious build error that could have been caught by
> > > simply building the code before pushing out the patch.
> > > 
> > 
> > Hi Jes,
> > 
> > Just tested again, as I have tested before submitting the blamed
> > patch,
> > and as we test on every single new patch in our build automation.
> > 
> > both combinations CONFIG_MLX5_EN_RXNFC=y/n work on latest net-next,
> > what am i missing ?
> 
> Linus' tree:
> 
> [jes@...as linux.git]$ grep mlx5e_get_rxnfc
> drivers/net/ethernet/mellanox/mlx5/core/*.c
> drivers/net/ethernet/mellanox/mlx5/core/en/*.h
> drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:static int
> mlx5e_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *info,
> u32
> *rule_locs)
> drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:	.get_rxnfc
> = mlx5e_get_rxnfc,
> drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c:int
> mlx5e_get_rxnfc(struct net_device *dev,
> drivers/net/ethernet/mellanox/mlx5/core/en/fs.h:int
> mlx5e_get_rxnfc(struct net_device *dev,
> 
> static vs non static functions, with a prototype that is non static.

But only one prototype can be selected and it is according
CONFIG_MLX5_EN_RXNFC

when CONFIG_MLX5_EN_RXNFC=n then the static prototype will be selected
and the other one will be compiled out.

when CONFIG_MLX5_EN_RXNFC=y the non static prototype will be selected
and the static one will be compiled out.

So no issue here.

> 
> Jes