netdev - Re: [PATCH 1/5] iwlegacy: 3945: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190625050834.55F3160117@smtp.codeaurora.org>
Date:   Tue, 25 Jun 2019 05:08:34 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Johannes Berg <johannes.berg@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stanislaw Gruszka <sgruszka@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/5] iwlegacy: 3945: no need to check return value of
 debugfs_create functions

Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> When calling debugfs functions, there is no need to ever check the
> return value.  This driver was saving the debugfs file away to be
> removed at a later time.  However, the 80211 core would delete the whole
> directory that the debugfs files are created in, after it asks the
> driver to do the deletion, so just rely on the 80211 core to do all of
> the cleanup for us, making us not need to keep a pointer to the dentries
> around at all.
> 
> This cleans up the structure of the driver data a bit and makes the code
> a tiny bit smaller.
> 
> Cc: Stanislaw Gruszka <sgruszka@...hat.com>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-wireless@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

2 patches applied to wireless-drivers-next.git, thanks.

f503c7695343 iwlegacy: 3945: no need to check return value of debugfs_create functions
ffb92649f4d9 iwlegacy: 4965: no need to check return value of debugfs_create functions

-- 
https://patchwork.kernel.org/patch/10990125/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches