netdev - Re: [PATCH bpf-next] bpf: fix compiler warning with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Jun 2019 16:32:50 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yonghong Song <yhs@...com>, ast@...com, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     kernel-team@...com, arnd@...db.de
Subject: Re: [PATCH bpf-next] bpf: fix compiler warning with CONFIG_MODULES=n

On 06/26/2019 02:35 AM, Yonghong Song wrote:
> With CONFIG_MODULES=n, the following compiler warning occurs:
>   /data/users/yhs/work/net-next/kernel/trace/bpf_trace.c:605:13: warning:
>       ‘do_bpf_send_signal’ defined but not used [-Wunused-function]
>   static void do_bpf_send_signal(struct irq_work *entry)
> 
> The __init function send_signal_irq_work_init(), which calls
> do_bpf_send_signal(), is defined under CONFIG_MODULES. Hence,
> when CONFIG_MODULES=n, nobody calls static function do_bpf_send_signal(),
> hence the warning.
> 
> The init function send_signal_irq_work_init() should work without
> CONFIG_MODULES. Moving it out of CONFIG_MODULES
> code section fixed the compiler warning, and also make bpf_send_signal()
> helper work without CONFIG_MODULES.
> 
> Fixes: 8b401f9ed244 ("bpf: implement bpf_send_signal() helper")
> Reported-By: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Yonghong Song <yhs@...com>

Applied, thanks!