netdev - Re: [PATCH] bonding: Always enable vlan tx offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190626152505.GB2424@nanopsycho>
Date:   Wed, 26 Jun 2019 17:25:05 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     davem@...emloft.net, sdf@...gle.com, jianbol@...lanox.com,
        jiri@...lanox.com, mirq-linux@...e.qmqm.pl, willemb@...gle.com,
        sdf@...ichev.me, j.vosburgh@...il.com, vfalico@...il.com,
        andy@...yhouse.net, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: Always enable vlan tx offload

Wed, Jun 26, 2019 at 10:08:44AM CEST, yuehaibing@...wei.com wrote:
>We build vlan on top of bonding interface, which vlan offload
>is off, bond mode is 802.3ad (LACP) and xmit_hash_policy is
>BOND_XMIT_POLICY_ENCAP34.
>
>Because vlan tx offload is off, vlan tci is cleared and skb push
>the vlan header in validate_xmit_vlan() while sending from vlan
>devices. Then in bond_xmit_hash, __skb_flow_dissect() fails to
>get information from protocol headers encapsulated within vlan,
>because 'nhoff' is points to IP header, so bond hashing is based
>on layer 2 info, which fails to distribute packets across slaves.
>
>This patch always enable bonding's vlan tx offload, pass the vlan
>packets to the slave devices with vlan tci, let them to handle
>vlan implementation.
>
>Fixes: 278339a42a1b ("bonding: propogate vlan_features to bonding master")
>Suggested-by: Jiri Pirko <jiri@...nulli.us>
>Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>

Could you please do the same for team? Thanks!