netdev - Re: [PATCH net-next 12/18] ionic: Add async link status check and basic stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4804434c-166e-8829-972b-a245da3d987f@pensando.io>
Date:   Wed, 26 Jun 2019 08:54:11 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 12/18] ionic: Add async link status check and
 basic stats

On 6/25/19 4:47 PM, Jakub Kicinski wrote:
> On Thu, 20 Jun 2019 13:24:18 -0700, Shannon Nelson wrote:
>> +	/* filter out the no-change cases */
>> +	if ((link_up && netif_carrier_ok(netdev)) ||
>> +	    (!link_up && !netif_carrier_ok(netdev)))
> nit: these are both bools, you can compare them:
>
> 	if (link_up == netif_carrier_ok(netdev))
>
>> +		return;

Yep - thanks.
sln