netdev - Re: [PATCH net] ipv4: fix suspicious RCU usage in fib_dump_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190626.090841.1832076350011087887.davem@davemloft.net>
Date:   Wed, 26 Jun 2019 09:08:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, sbrivio@...hat.com,
        dsahern@...il.com, syzkaller@...glegroups.com
Subject: Re: [PATCH net] ipv4: fix suspicious RCU usage in
 fib_dump_info_fnhe()

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 26 Jun 2019 03:04:50 -0700

> sysbot reported that we lack appropriate rcu_read_lock()
> protection in fib_dump_info_fnhe()
> 
> net/ipv4/route.c:2875 suspicious rcu_dereference_check() usage!
> 
> other info that might help us debug this:
 ...
> Fixes: ee28906fd7a1 ("ipv4: Dump route exceptions if requested")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Stefano Brivio <sbrivio@...hat.com>
> Cc: David Ahern <dsahern@...il.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied, we can adjust the 'err' initialization or whatever as a followup.